WIP: Handle ro /boot #116
WIP: Handle ro /boot #116
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
I think we would also need to ensure_writable_efi() since we want to mount /boot/efi as read-only as well right? This should probably be done in efi.rs? Also, we'd need to tweak the kola tests a little bit so e.g.
bootupd/tests/kola/test-bootupd
Line 118 in 0be1b27
| } | ||
| let status = std::process::Command::new("mount") | ||
| .args(&["-o", "remount,rw"]) | ||
| .arg(p.as_os_str()) |
There was a problem hiding this comment.
We can directly pass p here without as_os_str() since Path implements the AsRef<OsStr> trait right?
|
Moving to #118 |
No description provided.